Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javadoc missing on some public BeanDefinitionParserDelegate methods #23349

Closed
rodwiddowson opened this issue Jul 24, 2019 · 0 comments
Closed

Javadoc missing on some public BeanDefinitionParserDelegate methods #23349

rodwiddowson opened this issue Jul 24, 2019 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.1.9

Comments

@rodwiddowson
Copy link

Affects: \2.5.1 (also master)

I have inherited some code and was doing some maintenance inside. This code called
BeanDefinitionParserDelegate#parseCustomElement(Element) and now also calls BeanDefinitionParserDelegate#parseCustomElement(Element, BeanDefinition).

I noted that these methods have no javadoc and this engendered a question "How mainstream is this/are we doing the right thing". Having eyeballed the (Spring) code I'm reasonably sure that this the right thing and whilst I'd imagine that custom parsers are not mainstream I'm comfortable with the code.

But can we add some javadoc? I'll try and pull together a PR if it would help. but I note that there are other methods in this class which are missing javadoc and I'd not be comfortable adding it to them.

Thanks

/Rod
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 24, 2019
@jhoeller jhoeller self-assigned this Aug 1, 2019
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 1, 2019
@jhoeller jhoeller added this to the 5.1.9 milestone Aug 1, 2019
@jhoeller jhoeller changed the title Javadoc missing on some Public methods on org.springframework.beans.factory.xml.BeanDefinitionParserDelegate Javadoc missing on some public BeanDefinitionParserDelegate methods Aug 1, 2019
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.0.x labels Aug 1, 2019
Closed
Closed
jhoeller added a commit that referenced this issue Aug 1, 2019
@jhoeller
Document all remaining public methods on BeanDefinitionParserDelegate
24b9bb9 
Closes gh-23349
jhoeller added a commit that referenced this issue Aug 1, 2019
@jhoeller
Document all remaining public methods on BeanDefinitionParserDelegate
f99b2f1 
Closes gh-23349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.1.9
Development

No branches or pull requests
3 participants
@rodwiddowson @jhoeller @spring-projects-issues