Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpringValidatorAdapter's ObjectError subclass is not Serializable #23181

Closed
nai2 opened this issue Jun 24, 2019 · 0 comments
Closed

SpringValidatorAdapter's ObjectError subclass is not Serializable #23181

nai2 opened this issue Jun 24, 2019 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: regression A bug that is also a regression
Milestone
5.1.9

Comments

@nai2
Copy link

nai2 commented Jun 24, 2019

Since 5.1.7.RELEASE SerializationFailedException happens when storing BindingResult.getAllErrors() with Redis.

In a1efe3c SpringValidatorAdapter was changed to use anonymous class for ObjectError.
But such the implementation should be avoided because ObjectError implements Serializable.

Affects: 5.1.7.RELEASE
SEI CERT Oracle Coding Standard for Java
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 24, 2019
@jhoeller jhoeller changed the title Avoid anonymous class for Serializable SpringValidatorAdapter's ObjectError subclass is not Serializable Jun 24, 2019
@jhoeller jhoeller self-assigned this Jun 24, 2019
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: regression A bug that is also a regression and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 24, 2019
@jhoeller jhoeller added this to the 5.1.9 milestone Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: regression A bug that is also a regression
Projects
None yet
Milestone
5.1.9
Development

No branches or pull requests
3 participants
@jhoeller @nai2 @spring-projects-issues