MockHttpServletRequestBuilder does not allow invalid content type for testing [SPR-17643]

[spring-projects-issues]

dmitry87 opened SPR-17643 and commented

 

Invalid mime type "yaml": does not contain '/'
org.springframework.http.InvalidMediaTypeException: Invalid mime type "yaml": does not contain '/'
 at org.springframework.http.MediaType.parseMediaType(MediaType.java:512)
 at org.springframework.test.web.servlet.request.MockHttpServletRequestBuilder.contentType(MockHttpServletRequestBuilder.java:277)

One of the app in stack sends invalid content type. Currently it is impossible to cover this in Unit test because MockHttpServletRequestBuilder uses MediaType.parse(contentType: String).toString() to get the value and it fails to get to ExceptionHandler

I propose that MockHttpServletRequestBuilder could accept any string for contentType. In this case when we send payload with invalid(unparsable) contentType to our controller we will handle InvalidMediaTypeException with our exception handler in Unit tests

 

---

Affects: 5.1.3

Referenced from: pull request #2077

[spring-projects-issues]

Juergen Hoeller commented

I suppose you can set the Content-Type header directly for the time being? Otherwise you could also modify the content type on the MockHttpServletRequest instance itself where no such parsing is in place.

[spring-projects-issues]

dmitry87 commented

Juergen Hoeller thanks, this helped!
https://github.com/spring-projects/spring-framework/pull/2079/files

[rstoyanchev]

This is now superseded by #2079.