Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormHttpMessageConverter doesn't support utf-8 filename [SPR-16061] #20610

Closed
spring-projects-issues opened this issue Oct 12, 2017 · 1 comment
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket)

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Oct 12, 2017

Xinyi.Liu opened SPR-16061 and commented

I want to use FeignClient to pass MultipartFile .https://github.com/pcan/feign-client-test this project doesn't work with chinese filename,maybe all non-ascII filename.
At first i find this jira #19115
then i upgrade spring-boot-starter to 1.5.7.RELEASE
but it still doesn't work!
Then i debuged again to find why,FormHttpMessageConverter line 408 getFilename seems to support filename*= , but FormHttpMessageConverter line 368 doesn't pass a charset to HttpHeaders line 682 , and at line 708 charset seems to be Deprecated.
I tried UrlEncoder to encode filename and set FormHttpMessageConverter.setMultipartCharset
in github project file FeignSpringFormEncoder,none of my tries works.


Affects: 4.3.11

Reference URL: https://github.com/pcan/feign-client-test

Issue Links:

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Jul 10, 2018

Brian Clozel commented

Hi Xinyi.Liu,

Sorry for the late feedback.

Before you raised this issue, we've improved the behavior there in #18979 - filenames should support utf-8 by default now.

Do you have a small code snippet I can take a look at that reproduces this issue? Looking at the Feign support project is a bit too much scope for this.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket)
Projects
None yet
Development

No branches or pull requests

2 participants