Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InvocableHandlerMethod calls makeAccessible(getBridgedMethod()) on every call [SPR-15230] #19795

Closed
spring-projects-issues opened this issue Feb 7, 2017 · 1 comment
Closed

InvocableHandlerMethod calls makeAccessible(getBridgedMethod()) on every call [SPR-15230] #19795

spring-projects-issues opened this issue Feb 7, 2017 · 1 comment
Assignees
@rstoyanchev
Labels
in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement
Milestone
5.3.10

Comments

@spring-projects-issues
Copy link
Collaborator

Gary Russell opened SPR-15230 and commented

This could be done once in the HandlerMethod ctor where the field is set up, although perhaps getBridgedMethod() should be final ?

Affects: 4.3.6
@spring-projects-issues spring-projects-issues added in: messaging Issues in messaging modules (jms, messaging) status: waiting-for-triage An issue we've not yet triaged or decided on type: enhancement A general enhancement and removed type: enhancement A general enhancement labels Jan 11, 2019
@rstoyanchev rstoyanchev added this to the 5.3.10 milestone Sep 7, 2021
@rstoyanchev rstoyanchev added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 7, 2021
@rstoyanchev rstoyanchev self-assigned this Sep 7, 2021
@rstoyanchev
Copy link
Contributor

We generally re-create the InvocableHandlerMethod as a wrapper around HandlerMethod but you have a point that this could probably be moved up to HandlerMethod at the point where bridgedMethod is initialized. I'll have a closer look at all the InvocableHandlerMethod variants we have in web and messaging code.

@sync-by-unito sync-by-unito bot mentioned this issue Sep 15, 2021
Closed
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@rstoyanchev @lxbzmy
Improve HandlerMethod#bridgedMethod initialization
8a124c1 
Ensure makeAccessible is called once when the bridgedMethod is
initialized.

Closes spring-projectsgh-19795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.10
Development

No branches or pull requests
2 participants
@rstoyanchev @spring-projects-issues