SimpleTriggerFactoryBean and CronTriggerFactoryBean fail without jobDetail [SPR-13604]

[spring-projects-issues]

Martin Benda opened SPR-13604 and commented

Factory beans SimpleTriggerFactoryBean and CronTriggerFactoryBean throw NPE when their jobDetail property is not set. This makes it impossible to create triggers without associated job detail (something that we need in our application and that worked fine in Spring 3.x). Moreover, the jobDetail null check in afterPropertiesSet (SimpleTriggerFactoryBean:221) is useless, because jobDetail is dereferenced without any null checking later in this method.

Making it possible to create triggers without job detail will make these bean factories more flexible and should not break any current uses of these beans.

---

Affects: 3.2.16, 4.2.3

Issue Links:

• Require Jackson 2.1+, Quartz 2.1.4+, EhCache 2.5+ [SPR-11262] #15887 Require Jackson 2.1+, Quartz 2.1.4+, EhCache 2.5+

Referenced from: pull request #896, and commits 2970065, 8adff1b, 67a65ea

Backported to: 3.2.17

[spring-projects-issues]

Martin Benda commented

Pull request URL added.

[spring-projects-issues]

Martin Benda commented

Changing "Affects Version/s" to 4.2.3; issue is still present in the latest version.

[spring-projects-issues]

Juergen Hoeller commented

As far as I can see, this never worked with Cron/SimpleTriggerFactoryBean... Are you maybe referring to the old Cron/SimpleTriggerBean for Quartz 1.x where this actually worked?

This is worth fixing in any case. It's just not a regression in those particular classes then.

Juergen

[spring-projects-issues]

Stéphane Nicoll commented

Fixed on master and available in 4.3.0.BUILD-SNAPSHOT in a couple of hours. Juergen Hoeller can you please review and backport to 4.2?

[spring-projects-issues]

Juergen Hoeller commented

Sure, will do...

[spring-projects-issues]

Martin Benda commented

As far as I can see, this never worked with Cron/SimpleTriggerFactoryBean... Are you maybe referring to the old Cron/SimpleTriggerBean for Quartz 1.x where this actually worked?

Yes, you are right, I was referring to SimpleTriggerBean from Spring 3.2.8.RELEASE.

Thanks!