Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support global @MessageExceptionHandler [SPR-12696] #17293

Closed
spring-projects-issues opened this issue Feb 5, 2015 · 3 comments
Closed

Support global @MessageExceptionHandler [SPR-12696] #17293

spring-projects-issues opened this issue Feb 5, 2015 · 3 comments
Assignees
Labels
in: messaging Issues in messaging modules (jms, messaging) in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Feb 5, 2015

Alex opened SPR-12696 and commented

I find useful to annotate a class with @ControllerAdvice so that the same error handler is used for multiple controllers.

I would like to do the same, i.e. having some kind of class with a special annotation where I would put my @MessageExceptionHandler methods


Affects: 4.1.4

Issue Links:

@spring-projects-issues
Copy link
Collaborator Author

Rossen Stoyanchev commented

@ControllerAdvice is in spring-web so we can't use that as you said. Even if we were to create @ControllerAdvice today, putting it in spring-core still might not help much since the @MessageExceptionHandler could be used with JMS annotated methods too (which are not @Controller) and also the upcoming annotated event listeners support. At present the exception handling methods are only supported with STOMP over WebSocket.

So we need to come up with something analogous for messaging.

@spring-projects-issues
Copy link
Collaborator Author

Rossen Stoyanchev commented

I'm scheduling it for consideration in 4.2.

@spring-projects-issues
Copy link
Collaborator Author

Rossen Stoyanchev commented

Modified title (was: "Something like @ControllerAdvice but for controllers using @MessageMapping")

@spring-projects-issues spring-projects-issues added in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.2 RC1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: messaging Issues in messaging modules (jms, messaging) in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants