When specified the Non-existent package using @ControllerAdvice(basePackages), has been applied to all controllers. [SPR-12510]

[spring-projects-issues]

Kazuki Shimizu opened SPR-12510 and commented

e.g)

package io.github.kazuki43zoo.app;

import org.springframework.web.bind.annotation.ControllerAdvice;
import org.springframework.web.bind.annotation.ModelAttribute;


@ControllerAdvice(basePackages = "xxxx")
public class AppControllerAdvice {

    @ModelAttribute("appCommonMessage")
    public String commonMessage() {
        System.out.println("AppControllerAdvice#appCommonMessage() called.");
        return "Hello in AppControllerAdvice.";
    }

}

Above @ModelAttribute method has been applied to the all controllers.( e.g: controllers under io.github.kazuki43zoo.app package).

I think feel unnatural in this behavior.
This behavior is specification ?

As related information ..
When specified the Non-existent package using @ComponentScan(basePackages), controller is not scanned.

I think should be changed to the same behavior with @CompnentScan.

How do think ?

---

Affects: 4.0.8, 4.1.2

Issue Links:

• Base packages referenced from @ControllerAdvice must contain at least one Controller [SPR-12506] #17111 Base packages referenced from @ControllerAdvice must contain at least one Controller ("duplicates")
• @ControllerAdvice(basePackageClasses) do the prefix search by package name. [SPR-12509] #17114 @ControllerAdvice(basePackageClasses) do the prefix search by package name.

Backported to: 4.0.9

[spring-projects-issues]

Juergen Hoeller commented

This one has been fixed in the latest 4.1.3 snapshot already and is also scheduled for a backport to 4.0.9. See my comment on #17111 for details.

Juergen

[spring-projects-issues]

Kazuki Shimizu commented

Hi Juergen,

Thank you for answer.
I confirmed that it has been resolved in 4.1.3.BUILD-SNAPSHOT :)

[spring-projects-issues]

Juergen Hoeller commented

Good to hear!

As for #17114, we will probably only fix this in the 4.1.x line - but also in time for 4.1.3 early next week.

Juergen

[spring-projects-issues]

Kazuki Shimizu commented

we will probably only fix this in the 4.1.x line

No problem !