SimpleJdbcInsert should take Map<String, ?> as arg instead of Map<String, Object> [SPR-12462]

[spring-projects-issues]

The Alchemist opened SPR-12462 and commented

Description

I would like to do something like:

SimpleJdbcInsert insert = new SimpleJdbcInsert(dataSource).withTableName("x");
Map<String, Number> args = new HashMap<>();
args.put("one", 1);
args.put("two", 2);
insert.setColumnNames(Arrays.asList("one", "two"));
insert.execute(args );

However, this doesn't work because SimpleJdbcInsertOperations takes Map<String, Object as an argument for its methods instead of Map<String, ?>.

GitHub Pull Request Link

#700

---

Affects: 4.1.2

[spring-projects-issues]

Juergen Hoeller commented

Fixed for 4.1.3 now, making it consistent with Map<String, ?> declarations in NamedParameterJdbcTemplate and many other places. It was simply an oversight that SimpleJdbcInsert was more restrictive there.

However, note that we are only doing this for incoming parameters (being lenient for what we accept) while we're still declaring concrete value types for Maps returned from Spring API methods.

While being at it, I've done a somewhat larger revision of related JDBC accessor code, e.g. also consistently using LinkedHashMap for adapting incoming parameters (preserving a user-specified order when coming from vararg arrays in particular, even if just for logging purposes).

Juergen

[spring-projects-issues]

The Alchemist commented

Thanks, Juergen Hoeller!