ShallowEtagHeaderFilter is not Servlet 2.5 compatible [SPR-12414]

[spring-projects-issues]

Johannes Graham opened SPR-12414 and commented

org.springframework.web.filter.ShallowEtagHeaderFilter calls javax.servlet.http.HttpServletResponse.getHeader, which was added in Servlet 3.0

Stack Trace:

java.lang.NoSuchMethodError: javax.servlet.http.HttpServletResponse.getHeader(Ljava/lang/String;)Ljava/lang/String;
        at org.springframework.web.filter.ShallowEtagHeaderFilter.isEligibleForEtag(ShallowEtagHeaderFilter.java:153) ~[spring-web-4.1.1.RELEASE.jar:4.1.1.RELEASE]
        at org.springframework.web.filter.ShallowEtagHeaderFilter.updateResponse(ShallowEtagHeaderFilter.java:102) ~[spring-web-4.1.1.RELEASE.jar:4.1.1.RELEASE]
        at org.springframework.web.filter.ShallowEtagHeaderFilter.doFilterInternal(ShallowEtagHeaderFilter.java:84) ~[spring-web-4.1.1.RELEASE.jar:4.1.1.RELEASE]
        at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-4.1.1.RELEASE.jar:4.1.1.RELEASE]
        at org.springframework.web.filter.CompositeFilter$VirtualFilterChain.doFilter(CompositeFilter.java:112) [spring-web-4.1.1.RELEASE.jar:4.1.1.RELEASE]

---

Affects: 4.0.7, 4.1.1

Issue Links:

• ShallowEtagHeaderFilter should not set ETags to non-cached resources [SPR-11110] #15736 ShallowEtagHeaderFilter should not set ETags to non-cached resources

Referenced from: commits 1823ce1, bf9295b

Backported to: 4.0.8

[spring-projects-issues]

Juergen Hoeller commented

Good catch! As of 4.1.2 and 4.0.8, ShallowEtagHeaderFilter skips its "Cache-Control" header check - the one introduced in #15736 - on Servlet 2.5 containers.

This will be available in the upcoming 4.1.2/4.0.8.BUILD-SNAPSHOT within an hour. Please give it a try if you have the chance...

Juergen