Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JndiLocatorDelegate.isDefaultJndiEnvironmentAvailable() should apply stronger checks [SPR-12223] #16838

Closed
spring-projects-issues opened this issue Sep 18, 2014 · 4 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Phil Webb opened SPR-12223 and commented

Calling JndiLocatorDelegate.isDefaultJndiEnvironmentAvailable() always seems to return true.


Affects: 4.1 GA

Referenced from: commits 2667956, 7f8d611, 2077388

@spring-projects-issues
Copy link
Collaborator Author

Phil Webb commented

Juergen Hoeller Is this one a backport candidate?

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Good point. However, the additional getEnvironment() call doesn't actually seem to help on Linux and Windows: The corresponding test fails both on the CI server and on my local development machine, with the getEnvironment() call apparently returning normally and therefore still suggesting the availability of a default JNDI environment... Could it be that it only helps on Mac OS? This may be a good enough effect but it isn't really a strong backport candidate then.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

Phil Webb commented

It would be good to find a consistent way to detect JNDI. The test is used to add a JndiPropertySource which ends up just catching NamingException each time.

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

As per our research, the problem seems to be a side effect from other JNDI tests in our test suite since the test does pass in isolation on Windows as well. We'll fix the test arrangements accordingly and will keep the stronger JNDI environment check in place for 4.1.1 then.

Juergen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants