Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ordering of conditions [SPR-12219] #16833

Closed
spring-projects-issues opened this issue Sep 17, 2014 · 0 comments
Closed

Support ordering of conditions [SPR-12219] #16833

spring-projects-issues opened this issue Sep 17, 2014 · 0 comments
Assignees
@philwebb
Labels
type: enhancement A general enhancement
Milestone
4.1.1

Comments

@spring-projects-issues
Copy link
Collaborator

Phil Webb opened SPR-12219 and commented

Some Condition implementations are inherently more expensive to run than others. For example, Spring Boot's OnClassCondition is very cheap, where as OnBeanCondition takes much longer to evaluate.

By ordering conditions and sorting them before evaluation we should be able to improve performance.

Referenced from: commits 70b5f31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
4.1.1
Development

No branches or pull requests
2 participants
@philwebb @spring-projects-issues