Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SessionDisconnectEvent should extend AbstractSubProtocolEvent [SPR-12156] #16770

Closed
spring-projects-issues opened this issue Sep 5, 2014 · 1 comment
Closed

SessionDisconnectEvent should extend AbstractSubProtocolEvent [SPR-12156] #16770

spring-projects-issues opened this issue Sep 5, 2014 · 1 comment
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
4.1.1

Comments

@spring-projects-issues
Copy link
Collaborator

Sergi Almar opened SPR-12156 and commented

All subprotocol events extends from AbstractSubProtocolEvent except SessionDisconnectEvent which extends from the general ApplicationEvent. It should extend AbstractSubProtocolEvent to be consistent with the other ones.

Affects: 4.1 GA

Referenced from: commits dc57cb2

1 votes, 2 watchers
@spring-projects-issues
Copy link
Collaborator Author

Rob Winch commented

This would be beneficial from my perspective. Currently, the SessionDisconnectEvent does not allow accessing user related information in it (i.e. principal).

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.1.1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
4.1.1
Development

No branches or pull requests
2 participants
@rstoyanchev @spring-projects-issues