Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad type comparison in ReflectionHelper.getTypeDifferenceWeight(List<TypeDescriptor> paramTypes, List<TypeDescriptor> argTypes) [SPR-11306] #15930

Closed
spring-projects-issues opened this issue Jan 13, 2014 · 0 comments
Closed

Bad type comparison in ReflectionHelper.getTypeDifferenceWeight(List<TypeDescriptor> paramTypes, List<TypeDescriptor> argTypes) [SPR-11306] #15930

spring-projects-issues opened this issue Jan 13, 2014 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
4.0.1

Comments

@spring-projects-issues
Copy link
Collaborator

Zoltan Farkas opened SPR-11306 and commented

Bad type comparison in

ReflectionHelper.getTypeDifferenceWeight(List<TypeDescriptor> paramTypes, List<TypeDescriptor> argTypes)

At line 132

if (paramType.equals(superClass)) {

This comparison will never be true since paramType class is not the same sa superClass class:

TypeDescriptor paramType = paramTypes.get(i);

and

Class<?> superClass = argType.getClass().getSuperclass();

This issue was highlighted by findbugs.

Affects: 3.2.6, 4.0 GA

Backported to: 3.2.7
@spring-projects-issues spring-projects-issues added type: bug A general bug status: backported An issue that has been backported to maintenance branches in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.0.1 milestone Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
4.0.1
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues