Upgrade embedded ASM version to 5.0.1 [SPR-11239]

[spring-projects-issues]

Juergen Hoeller opened SPR-11239 and commented

Spring Framework 4.0 ships with a patched version of ASM 4.2, accepting the 1.8 bytecode level and allowing use with CGLIB 3. This needs to be upgraded to ASM 5.0 once available, for official Java 8 support by ASM itself.

---

Affects: 4.0 GA

Issue Links:

• Upgrade to CGLIB 3.1 and Objenesis 2.1 [SPR-11226] #15851 Upgrade to CGLIB 3.1 and Objenesis 2.1
• Basic Java 8 bytecode compatibility for Spring 3.2.x through ASM 5.0.2 [SPR-11656] #16279 Basic Java 8 bytecode compatibility for Spring 3.2.x through ASM 5.0.2

[spring-projects-issues]

Juergen Hoeller commented

ASM 5.0 is available along with OpenJDK 8 GA already, so let's schedule our upgrade for Spring Framework 4.0.3 right away.

[spring-projects-issues]

Juergen Hoeller commented

A minor note: As of CGLIB 3.1 - which we upgraded to in Spring Framework 4.0.1 two months ago -, our patch in the ClassVisitor constructor and our dummy copy of asm.util.TraceClassVisitor do not seem to be necessary anymore, so I've removed them in the process of the ASM 5.0 upgrade.

That said, we do retain our patch in the ClassReader constructor, for forward compatibility with JDK 9. As with early JDK 8 builds, ASM seems to work fine for our purposes even against a new bytecode version, so it seems to be appropriate to still remove that hard check and rather attempt best-effort parsing.

Juergen

[spring-projects-issues]

Pether Sorling commented

5.0.1 has been released http://forge.ow2.org/forum/forum.php?forum_id=2303.

Bug fixes:
317132 ASM 5.0 do not supported JDK 1.5?
317131 Infinite loop in InstructionAdapter.invokestatic(...).
316691 Incorrect StackMapFrame calculations for large > 32k methods in Java 7.
317123 ASM5.0: Class MethodNode broken?
317127 duplicate entries in InnerClasses attribute.

[spring-projects-issues]

Juergen Hoeller commented

Fortunately, with our minimal repackaged version of ASM, only two classes had to be patched for a 5.0.1 upgrade to begin with.

In any case, just in time for the Spring Framework 4.0.3 release! Thanks for raising it...

Juergen