performancedrop due to repeated JDBC 3.0 getParameterType calls in setNull in StatementCreatorUtils [SPR-11100] #15726
Labels
in: data
Issues in data modules (jdbc, orm, oxm, tx)
status: backported
An issue that has been backported to maintenance branches
type: bug
A general bug
Milestone
M Claus opened SPR-11100 and commented
We notice a performance drop after we updated to a (much newer) library (3.2.5). We used to work on 3.0.5.
We connect to Oracle11g with ojdbc 11.2.0.4 drivers.
After some testing we noticed that the performance drop was introduced by a changed implementation in setNull. Our queries have lots of columns ~40 with many optional values. For every NULL value, the driver is now asked ps.getParameterMetaData().getParameterType(paramIndex). The drivers don't support this yet but will throw an exception.
We notice that calling this method 30ish times costs us extra time (around 100ms), which is quite noticable. Requests which require 2 inserts went from ~200ms to 400+ms. We omitted the getparametertype call by editing the source of 3.2.5 to check our hypothesis and the performance was restored to its old state.
Is it possible to cache the 'unsupported state' in case the databasedrivers do not support it, so it's only executed once per request.
Below is the oracle implementation of getParameterType
SQLException localSQLException = DatabaseError.createUnsupportedFeatureSqlException();
localSQLException.fillInStackTrace();
throw localSQLException;
PS: entered this issue as a bug because it impairs the function of the product
Somewhat related issue, different bug introduced due to the added functionality (#14818)
Affects: 3.2.5
Issue Links:
Referenced from: commits 2e15f94, 4c8a789
Backported to: 3.2.6
2 votes, 7 watchers
The text was updated successfully, but these errors were encountered: