Add support for javax.validation.executable.ValidateOnExecution [SPR-10641]

[spring-projects-issues]

Nick Williams opened SPR-10641 and commented

Bean Validation 1.1 added a @javax.validation.executable.ValidateOnExecution annotation meant to mark classes or methods whose method executions should be validated. This is in some ways quite synonymous with Spring's @Validated, but with broader implications.

@Validated is for classes and parameters only. @ValidateOnExecution applies to packages, classes, methods, and constructors (but not parameters). So, even if I configured the MethodValidationPostProcessor to look for @ValidateOnExecution by calling setValidatedAnnotationType it wouldn't match cases where the package or method was annotated.

Out of the box, if a MethodValidationPostProcessor is defined it seems like Spring should enable method validation if any of the following conditions are met:

• The package is annotated @Validated or @ValidateOnExecution
• The class is annotated @Validated or @ValidateOnExecution
• The constructor is annotated @Validated or @ValidateOnExecution (assuming Spring is responsible for the instantiation of the bean)
• The method is annotated @Validated or @ValidateOnExecution
• The parameter is annotated @Validated (to preserve current functionality)

This will necessitate:

• Expanding the @Target of @Validated to include packages, constructors, and methods
• Changing MethodPostProcessor to look for both annotations on the package, class, or method instead of just @Validated on the class
• Changing bean instantiation procedures to look for both annotations on the constructor

---

Affects: 4.0 M1

Issue Links:

• @Validated should allow ElementType.METHOD target [SPR-9174] #13812 @Validated should allow ElementType.METHOD target

1 votes, 4 watchers

[spring-projects-issues]

Nick Williams commented

Note: In BV 1.1, this:

@ValidateOnExecute
@GroupSequence({Group1.class, Group2.class})
public class Whatever {

Is equivalent to this in Spring:

@Validate({Group1.class, Group2.class})
public class Whatever {

What I don't know is whether a BV implementation like Hibernate Validator picks this up and uses it when Validator#validate is called. I think probably not. It should be tested, but assuming I'm right this change should be made as well.

[spring-projects-issues]

Nick Williams commented

Any chance to get this in Spring 4.0.0.Final to complete support for BV 1.1?

[spring-projects-issues]

Bulk closing outdated, unresolved issues. Please, reopen if still relevant.