Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix for multiple invocations of ImportBeanDefinitionRegistrars [SPR-9939] #14572

Closed
spring-projects-issues opened this issue Oct 31, 2012 · 3 comments
Labels
in: core Issues in core modules (aop, beans, core, context, expression)
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Oct 31, 2012

Oliver Drotbohm opened SPR-9939 and commented

I think this is a reasonable backport candidate as with Spring Data we don't want to force users on to 3.2 abruptly and the logs for the overridden bean definitions might lead users into thinking they're setting up their application context invalidly. Furthermore, even if the duplicate invocation doesn't cause any issues with our ImportBeanDefinitionRegistrar it will for implementations which use auto-generated bean names as they'll accidentally register two bean instances which might break autowiring by type as no unique bean then can be found.


This issue is a backport sub-task of #14558

Issue Links:

Referenced from: commits spring-projects/spring-hateoas@48b039a, spring-projects/spring-hateoas@3976ae1

@spring-projects-issues
Copy link
Collaborator Author

Oliver Drotbohm commented

Maybe worth mentioning that I am perfectly fine for this one not making it into 3.1.3. I just think it's important to have in the 3.1.x timeline before we officially declare it as done.

@spring-projects-issues
Copy link
Collaborator Author

Chris Beams commented

Acknowledged, thanks Ollie.

@spring-projects-issues
Copy link
Collaborator Author

Chris Beams commented

commit d547570bcd606abc6ac34a82930d36fb83c24002
Merge: a420e84 a9290d8
Author: Chris Beams <cbeams@vmware.com>
Commit: Chris Beams <cbeams@vmware.com>

    Merge branch 'backport-SPR-9925' into 3.1.x
    
    * backport-SPR-9925:
      Backport "Polish @Imports search code"
      Backport "Ensure @Imports are processed in correct order"
      Backport "Prevent duplicate @Import processing"
      Backport "Polish Javadoc for @Import"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression)
Projects
None yet
Development

No branches or pull requests

1 participant