Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobDetailFactoryBean missing properties to set description and durability on JobDetail [SPR-9080] #13718

Closed
spring-projects-issues opened this issue Jan 31, 2012 · 6 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jan 31, 2012

Scott Coldwell opened SPR-9080 and commented

When changing to Quartz 2.x we switched to using JobDetailFactoryBean instead of JobDetailBean (as noted in #12923). Along with this change we realized that JobDetailFactoryBean doesn't include properties for setting the description or durability that was previously available with JobDetailBean (since it extended JobDetail itself). As a workaround we have created our own copy of JobDetailFactoryBean which sets these properties correctly. I would be glad to submit a patch or fix, I just need to know the preferred method of doing so since I haven't contributed to spring before.


Issue Links:

Referenced from: commits f367619

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Good catch! Added for 3.1.1.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

Scott Coldwell commented

Thanks for the quick turn around on this!

@spring-projects-issues
Copy link
Collaborator Author

Federico Gaule commented

Is there a reason not to be 'requestsRecovery' property in the FactoryBean? Or should i open a new ticket for that one?

Thanks

@spring-projects-issues
Copy link
Collaborator Author

Craig Murphey commented

What was the bug filed to add requestsRecovery to JobDetailFactoryBean? I'm also looking for this feature.

@spring-projects-issues
Copy link
Collaborator Author

sreekanth commented

No its not fixed yet, its still missing in spring 3.2.3

@spring-projects-issues
Copy link
Collaborator Author

sreekanth commented

*Still Missing requestRecovery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants