Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Servlet 3.1 (JSR-340) [SPR-8193] #12842

Closed
spring-projects-issues opened this issue Apr 4, 2011 · 5 comments
Closed

Support Servlet 3.1 (JSR-340) [SPR-8193] #12842

spring-projects-issues opened this issue Apr 4, 2011 · 5 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Apr 4, 2011

Chris Beams opened SPR-8193 and commented

Servlet 3.1 (building on our Servlet 3.0 support in Spring 3.1)

http://www.jcp.org/en/jsr/detail?id=340


Issue Links:

@spring-projects-issues
Copy link
Collaborator Author

Rossen Stoyanchev commented

It looks like Tomcat 7.0.x and trunk have the proposed final draft of the spec and it will be included in Tomcat 7.0.39.

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

BTW, I've updated our Servlet API mocks to 3.0 in the meantime, and also checked them against Servlet 3.1: I've added get/setContentLengthLong since that was easy enough to do even when compiling against the Servlet API 3.0. The only other new 3.1 stuff was the protocol upgrade method and the ReadListener/WriteListener callbacks, all of which shouldn't be important for our user-visible mocks at this point. If we do need those facilities for internal testing purposes, let's use custom versions of those mocks with full 3.1 support.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Assigning the Servlet 3.1 issue to you, Rossen - since at this point, it's 'just' about using the protocol upgrade mechanism and offering some support for async reading and writing - there are no general features to catch up with as far as I can see.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

Rossen Stoyanchev commented

Sounds good.

@spring-projects-issues
Copy link
Collaborator Author

Rossen Stoyanchev commented

Not much else to do here. The primary reason to depend on Servlet 3.1 is the use of WebSocket support. Although it should be pointed out that Tomcat 7.0.47+ allows using the same WebSocket support with Servlet 3.0 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants