Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use implicit join to create Predicate if possible #3374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use implicit join to create Predicate if possible #3374

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Feb 19, 2024

Fix GH-3349

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 19, 2024
@quaff quaff mentioned this pull request Feb 19, 2024
Open
@quaff quaff marked this pull request as draft February 19, 2024 09:14
@quaff
Copy link
Contributor Author

quaff commented Feb 20, 2024 •
edited

It should mitigate GH-3274 and GH-3307 also.

@quaff quaff marked this pull request as ready for review February 20, 2024 02:02
@christophstrobl
Copy link
Member

Thank you @quaff! Would you mind adding some tests to verify the behaviour?

@quaff
Copy link
Contributor Author

quaff commented Feb 20, 2024

Thank you @quaff! Would you mind adding some tests to verify the behaviour?

I'm trying.

@quaff quaff marked this pull request as draft February 20, 2024 06:59
@quaff quaff marked this pull request as ready for review February 20, 2024 08:16
@quaff
Copy link
Contributor Author

quaff commented Feb 20, 2024

Thank you @quaff! Would you mind adding some tests to verify the behaviour?

I'm trying.

@christophstrobl Done!

@christophstrobl christophstrobl self-assigned this Feb 21, 2024
@quaff
Copy link
Contributor Author

quaff commented Mar 8, 2024

see https://docs.jboss.org/hibernate/orm/current/userguide/html_single/Hibernate_User_Guide.html#hql-implicit-join

@quaff quaff mentioned this pull request Apr 15, 2024
Open
@quaff
Copy link
Contributor Author

quaff commented Apr 24, 2024

There is a subtle change by this PR, since implicit join will use inner join, then IS_NULL will require ManyToOne relation entity exists but property of that entity is null, before this commit, it imply relation entity is null or property of entity is null. It's easy to keep the behavior as before, but I doubt it's right to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@christophstrobl christophstrobl

Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression for method-based query where predicate compares primary key of @ManyToOne relationship
3 participants
@quaff @christophstrobl @spring-projects-issues