Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a configuration property for the observation patterns of Spring Integration components #33099

Closed
wants to merge 1 commit into from
Closed

Provide a configuration property for the observation patterns of Spring Integration components #33099

wants to merge 1 commit into from

Conversation

artembilan
Copy link
Member

Spring Integration can instrument its component with an Observation according to the @EnableIntegrationManagement.observationPatterns value

  • Expose spring.integration.management.observation-patterns configuration property
  • Propagate this property into an @EnableIntegrationManagement in the IntegrationAutoConfiguration.IntegrationManagementConfiguration
  • Verify that property has an effect via IntegrationAutoConfigurationTests.integrationManagementInstrumentedWithObservation()

@artembilan
Add Spring Integration observationPatterns prop
277a1ca 
Spring Integration can instrument its component with an `Observation`
according to the `@EnableIntegrationManagement.observationPatterns` value

* Expose `spring.integration.management.observation-patterns` configuration property
* Propagate this property into an `@EnableIntegrationManagement` in the `IntegrationAutoConfiguration.IntegrationManagementConfiguration`
* Verify that property has an effect via `IntegrationAutoConfigurationTests.integrationManagementInstrumentedWithObservation()`
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 10, 2022
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 10, 2022
@philwebb philwebb added this to the 3.0.x milestone Nov 10, 2022
@philwebb philwebb added the status: blocked An issue that's blocked on an external project change label Nov 10, 2022
@philwebb
Copy link
Member

Considering this one a bug of omission, but we can't add it yet because we can't move to SNAPSHOTs before our next RC.

@artembilan
Copy link
Member Author

No. This is not a bug or omission.
An observation instrumentation is a new feature in Spring Integration 6.0.
Yes, we can squeeze this for the next release for Spring Boot in two week.
Or you can just move it as a theme of next Spring Boot 3.1 (or 3.0.1 if any).

Thanks

@philwebb
Copy link
Member

By "bug of omission" I meant that it's a feature we should ideally have support for in the 3.0 release since the feature was added in Spring Integration 6. I guess you're right though, it's really an enhancement. I still think it might be worth adding to 3.0 if we can. It seems low risk.

@philwebb philwebb added type: enhancement A general enhancement and removed type: bug A general bug labels Nov 10, 2022
@artembilan
Copy link
Member Author

Sounds good, Phil!
Sorry that I came up with this property a bit late.
Let's see if it can make it into 3.0!

@wilkinsona wilkinsona removed the status: blocked An issue that's blocked on an external project change label Nov 14, 2022
@wilkinsona wilkinsona changed the title Add Spring Integration observationPatterns prop Provide a configuration property for the observation patterns of Spring Integration components Nov 14, 2022
wilkinsona pushed a commit that referenced this pull request Nov 14, 2022
@artembilan @wilkinsona
Add config property for Spring Integration component observation
b87d5c7 
Spring Integration has introduced a new observationPatterns attribute
on EnableIntegrationManagement. Spring Boot auto-configures
EnableIntegrationManagement so this commit adds a property that
allows users to configure the patterns without declaring the
annotation themselves.

See gh-33099
wilkinsona added a commit that referenced this pull request Nov 14, 2022
@wilkinsona
Polish "Add config property for Spring Integration component observat…
31f5e76 
…ion"

See gh-33099
@philwebb philwebb modified the milestones: 3.0.x, 3.0.0 Nov 14, 2022
@Netyyyy Netyyyy mentioned this pull request Nov 25, 2022
Closed
@grandamp grandamp mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@artembilan @philwebb @wilkinsona @spring-projects-issues