Wavefront application tags differ from those used in a Spring Boot 2.x application #32844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
oppegard
commented
Oct 21, 2022
.../actuate/autoconfigure/metrics/export/wavefront/WavefrontMetricsExportAutoConfiguration.java
Outdated
Show resolved
Hide resolved
jonatan-ivanov
requested changes
Oct 25, 2022
.../actuate/autoconfigure/metrics/export/wavefront/WavefrontMetricsExportAutoConfiguration.java
Outdated
Show resolved
Hide resolved
.../actuate/autoconfigure/metrics/export/wavefront/WavefrontMetricsExportAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...ramework/boot/actuate/autoconfigure/tracing/wavefront/WavefrontTracingAutoConfiguration.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/boot/actuate/autoconfigure/wavefront/WavefrontProperties.java
Outdated
Show resolved
Hide resolved
philwebb
added
for: team-meeting
- Also fix use of application and service tags to reflect their meaning in Wavefront
philwebb
added
type: bug
philwebb
changed the title
philwebb
pushed a commit
that referenced
this pull request
Nov 17, 2022
Update `application-name` and `service-name` `management.wavefront` properties to align with Spring Boot 2.x support. The properties now use the wavefront terminology where `application` refers to an a collection of (micro)`services`. This commit also adds `cluster-name` and `shard-name` properties that can be used to add additional items to the `ApplicationTags`. See gh-32844
philwebb
added a commit
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fleshes out the use of Wavefront Application Tags, used in Wavefront to organize a service within a larger distributed application.
spring.application.nameif available.This PR add two new properties:
management.wavefront.tracing.cluster-namemanagement.wavefront.tracing.shard-nameIn wavefront-spring-boot these properties were
wavefront.application.clusterandwavefront.application.shard. I'm not sure if there's a way to migrate users of the old properties (same goes forwavefront.application.nameandwavefront.application.service).This PR also adds Application Tags to metrics exported by instances of
WavefrontMeterRegistry, replacing functionality from wavefront-spring-boot.