Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning that DefaultClientResources was not shutdown properly when using Lettuce with Actuator #28767

Closed
wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Nov 22, 2021

It is not the responsibility of ClientResourcesBuilderCustomizer to build ClientResources instance.

Fix:

i.l.c.r.DefaultClientResources WARN io.lettuce.core.resource.DefaultClientResources was not shut down properly, shutdown() was not called before it's garbage-collected. Call shutdown() or shutdown(long,long,TimeUnit)

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 22, 2021
…ance

Fix:
i.l.c.r.DefaultClientResources WARN io.lettuce.core.resource.DefaultClientResources was not shut down properly, shutdown() was not called before it's garbage-collected. Call shutdown() or shutdown(long,long,TimeUnit)
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 22, 2021
@wilkinsona wilkinsona added this to the 2.6.x milestone Nov 22, 2021
@snicoll snicoll modified the milestones: 2.6.x, 2.6.1 Nov 22, 2021
@snicoll snicoll self-assigned this Nov 22, 2021
@snicoll snicoll closed this in cdc2851 Nov 22, 2021
@snicoll
Copy link
Member

snicoll commented Nov 22, 2021

@quaff good catch, thanks again.

@wilkinsona wilkinsona changed the title LettuceMetricsAutoConfiguration should not build ClientResources instance Warning that DefaultClientResources was not shutdown properly when using Lettuce with Actuator Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants