Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See if we can drop the use of SocketUtils.findAvailableTcpPort() from EndpointWebMvcAutoConfigurationTests #9230

Closed
wilkinsona opened this issue May 15, 2017 · 1 comment
Labels
status: duplicate A duplicate of another issue type: task A general task

Comments

@wilkinsona
Copy link
Member

It's causing intermittent build failures like this:

org.springframework.boot.web.server.PortInUseException: Port 40224 is already in use
	at org.springframework.boot.web.embedded.undertow.UndertowServletWebServer.start(UndertowServletWebServer.java:168)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.startWebServer(ServletWebServerApplicationContext.java:293)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.finishRefresh(ServletWebServerApplicationContext.java:144)
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:545)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:122)
	at org.springframework.boot.actuate.autoconfigure.EndpointWebMvcAutoConfiguration.createChildManagementContext(EndpointWebMvcAutoConfiguration.java:178)
	at org.springframework.boot.actuate.autoconfigure.EndpointWebMvcAutoConfiguration.afterSingletonsInstantiated(EndpointWebMvcAutoConfiguration.java:144)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:771)
	at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:866)
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:542)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:122)
	at org.springframework.boot.actuate.autoconfigure.EndpointWebMvcAutoConfigurationTests.managementServerCanDisableSslWhenUsingADifferentPort(EndpointWebMvcAutoConfigurationTests.java:571)

It'd be nice if we could use 0 instead and let the OS allocate a port which is actually guaranteed to be available.

@wilkinsona
Copy link
Member Author

Duplicate of #9382

@wilkinsona wilkinsona marked this as a duplicate of #9382 Jul 29, 2017
@wilkinsona wilkinsona added the status: duplicate A duplicate of another issue label Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant