New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpringBootExceptionHandler thread local leak reported by Tomcat #40206
Comments
Thanks for the report, @stefanodelfalk. Are you making use of JNDI in your application? For example, are you configuring properties in JNDI and then consuming them through Spring's |
This is another problem that could be solved by #34616. Alternatively, a more specific fix would be to stop binding directly to |
Thanks a lot for looking into this, looking forward to #40592. FYI: in the application I'm working on customers have the option define data sources in JNDI. The javadoc on JndiLocatorDelegate.IGNORE_JNDI_PROPERTY_NAME seems to indicate that this should work even with ignore=true, so that may not be a problem. However, a bigger issue is that since the beginning of time we've asked them to set an application-critical property in Tomcat's web application , and it looks like that is ignored when I set spring.jndi.ignore=true, so the workaround wouldn't work for our particular case. (We've listed the log message as a known issue for now.) Thanks again. |
To reproduce (this was on Java 17.0.10, Tomcat 10.1.19, Spring Boot 3.2.4):
Tomcat's WebappClassLoaderBase.checkThreadLocalsForLeaks will log this as a severe problem when you stop the web application.
I can't really see a good way around this.
The text was updated successfully, but these errors were encountered: