Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate @MockBean and @SpyBean #39860

Closed
philwebb opened this issue Mar 8, 2024 · 4 comments
Closed

Deprecate @MockBean and @SpyBean #39860

philwebb opened this issue Mar 8, 2024 · 4 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@philwebb
Copy link
Member

philwebb commented Mar 8, 2024

With spring-projects/spring-framework#29917 fixed we should consider deprecating our versions.
@philwebb philwebb added this to the 3.x milestone Mar 8, 2024
@philwebb philwebb added the type: enhancement A general enhancement label Mar 8, 2024
@wanger26
Copy link
Contributor

@philwebb do we want to target release 2.3.0 with this change? Also are we thinking of marking those for removal at this time?

@philwebb
Copy link
Member Author

We'll probably look at this in Spring Boot 3.4.0 which will be the first release to build on Spring Framework 6.2. I'm not sure yet about when well mark the existing annotations for removal.

@wanger26
Copy link
Contributor

Okay sounds good. I can take this one on. Do we want to take this opportunity to migrate our own usages of those two annotations over to the new spring framework ones?

wanger26 added a commit to wanger26/spring-boot that referenced this issue Mar 10, 2024
@wanger26
CHORE - Deprecate @MockBean and @SpyBean in favor of Spring Framework…
4691a4d 
… classes

- Deprecate Deprecate @MockBean and @SpyBean in favor of Spring Framekworks 6.2.0 @MockitoBean and @MockitoSpy. See spring-projects/spring-framework@e1bbdf0
- Migrate usages of @MockBean and @SpyBean to @MockitoBean an d @MockitoSpy

spring-projects#39860

Signed-off-by: Jakob Wanger <jakobwanger@gmail.com>
wanger26 added a commit to wanger26/spring-boot that referenced this issue Mar 10, 2024
@wanger26
CHORE - Deprecate @MockBean and @SpyBean
4a8d848 
- Deprecate Deprecate @MockBean and @SpyBean in favor of Spring Framekworks 6.2.0 @MockitoBean and @MockitoSpy. See spring-projects/spring-framework@e1bbdf0
- Migrate usages of @MockBean and @SpyBean to @MockitoBean an d @MockitoSpy

spring-projects#39860

Signed-off-by: Jakob Wanger <jakobwanger@gmail.com>
@wanger26 wanger26 mentioned this issue Mar 10, 2024
Draft
@philwebb
Copy link
Member Author

Closing in favor of PR #39864 which we'll merge sometime after we create the 3.3.x branch. Thanks @wanger26!

@philwebb philwebb closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
@philwebb philwebb added status: superseded An issue that has been superseded by another and removed type: enhancement A general enhancement labels Mar 11, 2024
@philwebb philwebb removed this from the 3.x milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philwebb @wanger26