Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinIdle and MaxValidationTime properties missing for R2DBC pools #34724

Closed
marcelop3251 opened this issue Mar 22, 2023 · 2 comments
Closed

MinIdle and MaxValidationTime properties missing for R2DBC pools #34724

marcelop3251 opened this issue Mar 22, 2023 · 2 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@marcelop3251
Copy link

Spring boot version: 2.7.9, the spring-boot-project version of r2dbc more specifically the class
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/r2dbc/ConnectionFactoryConfigurations.java does not map the new property available in r2dbc-pool, in the case of minIdle the idea is to map this field?

See new field in
https://github.com/r2dbc/r2dbc-pool/blob/0.9.x/src/main/java/io/r2dbc/pool/ConnectionPoolConfiguration.java

Is there any specific reason for not having mapped?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 22, 2023
@wilkinsona
Copy link
Member

Thanks for spotting this. It looks like it was missed as part of #32328. I think we could consider that to be a bug, but I'd like to get some opinions from the rest of the team before we make a decision about the issue's milestone.

@wilkinsona wilkinsona added the for: team-meeting An issue we'd like to discuss as a team to make progress label Mar 23, 2023
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress labels May 8, 2023
@philwebb philwebb added this to the 2.7.x milestone May 8, 2023
@mhalbritter mhalbritter changed the title MinIdle mapping MinIdle property is missing for R2DBC pools May 10, 2023
@mhalbritter mhalbritter changed the title MinIdle property is missing for R2DBC pools MinIdle and MaxValidationTime properties missing for R2DBC pools May 10, 2023
@mhalbritter mhalbritter self-assigned this May 10, 2023
@mhalbritter mhalbritter modified the milestones: 2.7.x, 2.7.12 May 10, 2023
@mhalbritter
Copy link
Contributor

I added mappings for min-idle and max-validation-time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

5 participants