Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to OpenTelemetry 1.23.1 #34100

Closed
wilkinsona opened this issue Feb 6, 2023 · 5 comments
Closed

Upgrade to OpenTelemetry 1.23.1 #34100

wilkinsona opened this issue Feb 6, 2023 · 5 comments
Assignees
Labels
status: superseded An issue that has been superseded by another type: task A general task
Milestone

Comments

@wilkinsona
Copy link
Member

No description provided.

@wilkinsona wilkinsona added the type: dependency-upgrade A dependency upgrade label Feb 6, 2023
@wilkinsona wilkinsona added this to the 3.1.0-M1 milestone Feb 6, 2023
@wilkinsona
Copy link
Member Author

This upgrade requires some further investigation as it causes 3 failures in BaggagePropagationIntegrationTests.

@chicobento
Copy link
Contributor

Hi @wilkinsona , we stumble upon issue open-telemetry/opentelemetry-java#4918 regarding the usage of EC certificates with open-telemetry 1.19. The issue was fixed on otel 1.20.0.
Is there any chance of bumping otel to 1.20 for upcoming 3.0.3 ? Perhaps failures on BaggagePropagationIntegrationTests will not happen on 1.20.0.

ps: I know we can always override the bom version on the application level, but just saying.

@wilkinsona
Copy link
Member Author

Is there any chance of bumping otel to 1.20 for upcoming 3.0.3 ?

Unfortunately not. Whenever possible, we aim to only upgrade to new maintenance releases of dependencies in Boot's maintenance releases. If we'd shipped 3.0.0 with 1.20, we could have upgraded to 1.20.1 in a 3.0.x release, but we won't jump from 1.19.0 to 1.20 or later in 3.0.x.

I know we can always override the bom version on the application level, but just saying.

If you want to opt in to a new minor release, this is what you should do.

@chicobento
Copy link
Contributor

Just a curious thing, looking at otel-sdk release history they have rarely released patch versions so it looks like a Boot minor will be constantly behind and never get bug fixes. Hope that as otel-sdk get more stable they start following a more stable release cycle.

That said, the policy to keep 3pp minors within a Boot minor makes completely sense as it is complex to handle all the 3pps and their commitment to semver and minors maintenance. 👍🏻

@wilkinsona wilkinsona changed the title Upgrade to OpenTelemetry 1.22.0 Upgrade to OpenTelemetry 1.23.1 Feb 20, 2023
@philwebb philwebb modified the milestones: 3.1.0-M1, 3.1.x Feb 24, 2023
@eduanb
Copy link

eduanb commented Feb 24, 2023

Also worth noting is that 1.20 is needed to get Graal Native to work. Otherwise, you will see this error:

Caused by: java.lang.NoSuchFieldException: producerIndex

Here is the PR with more info
open-telemetry/opentelemetry-java#4832

@wilkinsona wilkinsona self-assigned this Mar 9, 2023
wilkinsona added a commit to wilkinsona/spring-boot that referenced this issue Mar 10, 2023
@wilkinsona wilkinsona modified the milestones: 3.1.x, 3.1.0-M2 Mar 10, 2023
@wilkinsona wilkinsona added type: task A general task status: superseded An issue that has been superseded by another and removed type: dependency-upgrade A dependency upgrade labels Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: task A general task
Projects
None yet
Development

No branches or pull requests

4 participants