Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remnants of AutoTimer support if possible #33247

Closed
wilkinsona opened this issue Nov 17, 2022 · 2 comments
Closed

Remove remnants of AutoTimer support if possible #33247

wilkinsona opened this issue Nov 17, 2022 · 2 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: task A general task

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Nov 17, 2022

Much of the AutoTimer support has been removed in favor of the observation support that's been added to WebClient, RestTemplate, and the like. We still have the public org.springframework.boot.actuate.metrics.AutoTimer interface but it's now only used by org.springframework.boot.actuate.metrics.data.MetricsRepositoryMethodInvocationListener. We may be able to remove it in favor of the observation support in Spring Data.

@wilkinsona wilkinsona added the type: task A general task label Nov 17, 2022
@wilkinsona wilkinsona added this to the 3.0.0 milestone Nov 17, 2022
@wilkinsona
Copy link
Member Author

wilkinsona commented Nov 18, 2022

We need to update the documentation based on the outcome of this issue. It shows examples of using @Timed on a @RestController which is no longer supported. We'll either need to remove the section entirely, or update it to use Spring Data Repository examples.

@wilkinsona
Copy link
Member Author

This isn't possible at this time. We'll leave things as they are in Boot 3.0 and migrate to the support that's coming in Spring Data in 3.1. I've opened #33282 to address the documentation around @Timed.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2022
@wilkinsona wilkinsona removed this from the 3.0.0 milestone Nov 21, 2022
@wilkinsona wilkinsona added the status: declined A suggestion or change that we don't feel we should currently apply label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant