Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpringBootMockResolver causes AopTestUtils.getUltimateTargetObject to recurse until the stack overflows when it calls it with Spring Security's authentication manager bean #32632

Closed
sbrannen opened this issue Oct 7, 2022 · 0 comments
Closed

SpringBootMockResolver causes AopTestUtils.getUltimateTargetObject to recurse until the stack overflows when it calls it with Spring Security's authentication manager bean #32632

sbrannen opened this issue Oct 7, 2022 · 0 comments
Assignees
@mhalbritter
Labels
type: bug A general bug
Milestone
2.7.8

Comments

@sbrannen
Copy link
Member

sbrannen commented Oct 7, 2022

As mentioned in spring-projects/spring-framework#29215 (comment), please consider introducing a custom, defensive variant of AopTestUtils.getUltimateTargetObject() in SpringBootMockResolver to avoid attempting to unwrap proxies backed by a non-static TargetSource.
@sbrannen sbrannen mentioned this issue Oct 7, 2022
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 7, 2022
@wilkinsona wilkinsona changed the title Avoid unwrapping proxy backed by non-static TargetSource in SpringBootMockResolver AopTestUtils.getUltimateTargetObject recurses until the stack overflows when called with Spring Security's authentication manager bean Oct 7, 2022
@wilkinsona wilkinsona changed the title AopTestUtils.getUltimateTargetObject recurses until the stack overflows when called with Spring Security's authentication manager bean SpringBootMockResolver causes AopTestUtils.getUltimateTargetObject to recurse until the stack overflows when it calls it with Spring Security's authentication manager bean Oct 7, 2022
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 7, 2022
@wilkinsona wilkinsona added this to the 2.6.x milestone Oct 7, 2022
@wilkinsona wilkinsona modified the milestones: 2.6.x, 2.7.x Nov 24, 2022
@mhalbritter mhalbritter mentioned this issue Jan 12, 2023
Closed
@mhalbritter mhalbritter self-assigned this Jan 12, 2023
@mhalbritter mhalbritter mentioned this issue Jan 12, 2023
Closed
@mhalbritter mhalbritter modified the milestones: 2.7.x, 2.7.8 Jan 12, 2023
@Netyyyy Netyyyy mentioned this issue Jan 20, 2023
Closed
@Netyyyy Netyyyy mentioned this issue Jan 28, 2023
Merged
krenson pushed a commit to krenson/test-push that referenced this issue Mar 15, 2023
Merged PR 29882: Update dependency org.springframework.boot:spring-bo…
ff09328 
…ot-starter-parent from 2.7.7 to 2.7.8 (patch)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `2.7.7` -> `2.7.8` |

---

### Release Notes

<details>
<summary>spring-projects/spring-boot</summary>

### [`v2.7.8`](https://github.com/spring-projects/spring-boot/releases/tag/v2.7.8)

[Compare Source](spring-projects/spring-boot@v2.7.7...v2.7.8)

#### ⭐ Noteworthy

-   The coordinates of the MySQL JDBC driver have [changed from `mysql:mysql-connector-java` to `com.mysql:mysql-connector-j`](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.7-Release-Notes#mysql-jdbc-driver).

#### 🐞 Bug Fixes

-   Devtools sets non-existent property spring.reactor.debug [#&#8203;33858](spring-projects/spring-boot#33858)
-   Failing calls to reactive health indicators are not logged [#&#8203;33774](spring-projects/spring-boot#33774)
-   Failure analysis of NoUniqueBeanDefinitionException reports "defined in null" when bean definition has no resource description [#&#8203;33765](spring-projects/spring-boot#33765)
-   NPE in RabbitProperties when user is given, but password not [#&#8203;33752](spring-projects/spring-boot#33752)
-   SDKMAN should not use repo.spring.io for releases [#&#8203;33708](spring-projects/spring-boot#33708)
-   Homebrew and Scoop should not use repo.spring.io for releases [#&#8203;33702](spring-projects/spring-boot#33702)
-   EndpointRequestMatcher should have a toString method [#&#8203;33690](spring-projects/spring-boot#33690)
-   It is not possible to provide a custom TransactionProvider bean for JOOQ [#&#8203;32899](spring-projects/spring-boot#32899)
-   SpringBootMockResolver causes AopTestUtils.getUltimateTargetObject to recurse until the stack overflows when it calls it with Spring Security's authentication manager bean [#&#8203;32632](spring-projects/spring-boot#32632)
-   Inconsistent discovery of parameter names for selectors in custom actuator endpoints [#&#8203;31240](spring-projects/spring-boot#31240)
-   `@DeprecatedConfigurationProperty` has no effect when declared on a record component's accessor method [#&#8203;29526](spring-projects/spring-boot#29526)
-   Headless mode is forced when banner.\* file is present. [#&#8203;28803](spring-projects/spring-boot#28803)
-   Diagnostics are poor when the JMX port used by the Maven start goal is in use [#&#8203;24044](spring-projects/spring-boot#24044)

#### 📔 Documentation

-   Replace "via" in documentat...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhalbritter mhalbritter

Labels
type: bug A general bug
Projects
None yet
Milestone
2.7.8
Development

No branches or pull requests
4 participants
@sbrannen @wilkinsona @spring-projects-issues @mhalbritter