Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring.security.saml2.relyingparty.registration.*.asserting-party.* properties contain unwanted hyphen in asserting-party #30785

Closed
wilkinsona opened this issue Apr 25, 2022 · 1 comment
Assignees
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: bug A general bug
Milestone

Comments

@wilkinsona
Copy link
Member

We try to avoid hyphens in property prefixes, reserving their use for the property's name. To align with this, spring.security.saml2.relyingparty.registration.*.asserting-party.* should be spring.security.saml2.relyingparty.registration.*.assertingparty.*.

@wilkinsona wilkinsona added this to the 2.7.0 milestone Apr 25, 2022
@wilkinsona wilkinsona added the type: bug A general bug label Apr 25, 2022
@mhalbritter mhalbritter self-assigned this Apr 25, 2022
@mhalbritter
Copy link
Contributor

mhalbritter commented Apr 25, 2022

When the 2.7.0 changelog is written, please change the note from RC 1, which still uses asserting-party to assertingparty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants