Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant EnabledOnJre, DisabledOnJre, DisabledForJreRange, and EnabledForJreRange annotations #29693

Closed
wilkinsona opened this issue Feb 9, 2022 · 2 comments
Assignees
Labels
type: task A general task
Milestone

Comments

@wilkinsona
Copy link
Member

We have some tests that are only enabled on certain JREs. As part of raising the Java baseline to 17, many (if not all) of them became redundant. We should review where they're used and remove them as appropriate.

@wilkinsona wilkinsona added this to the 3.0.x milestone Feb 9, 2022
@wilkinsona wilkinsona added the type: task A general task label Feb 9, 2022
@wilkinsona
Copy link
Member Author

There is also some usage in earlier branches that can be removed. For example, changelogSql in LiquibaseAutoConfigurationTests which appears to now pass on all supported JREs.

@wilkinsona wilkinsona modified the milestones: 3.0.x, 2.5.x Feb 23, 2022
@wilkinsona
Copy link
Member Author

wilkinsona commented Feb 23, 2022

It'll be easier to tackle the main-specific parts of this once JavaVersion supports Java 18. Without it, testing things like @ConditionalOnJava is limited as we only support a single JRE.

@wilkinsona wilkinsona added the status: on-hold We can't start working on this issue yet label Feb 23, 2022
@wilkinsona wilkinsona removed the status: on-hold We can't start working on this issue yet label Mar 9, 2022
@wilkinsona wilkinsona self-assigned this Mar 9, 2022
@wilkinsona wilkinsona modified the milestones: 2.5.x, 2.5.11 Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant