Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIGHTEEN to JavaVersion enum #29524

Closed
wilkinsona opened this issue Jan 21, 2022 · 4 comments
Closed

Add EIGHTEEN to JavaVersion enum #29524

wilkinsona opened this issue Jan 21, 2022 · 4 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

It might be a bit early for this as Java 18 is still subject to change. As things stand, we could use the new getAttributes() method on java.security.KeyStore to detect Java 18. Adding EIGHTEEN will allow us to continue to test the range support in @ConditionalOnJava once the constants for Java 16 and earlier have been removed.

@wilkinsona wilkinsona added the type: enhancement A general enhancement label Jan 21, 2022
@wilkinsona wilkinsona added this to the 2.5.x milestone Jan 21, 2022
@wilkinsona wilkinsona added the status: on-hold We can't start working on this issue yet label Jan 21, 2022
@dreis2211
Copy link
Contributor

If I may suggest java.time.Duration::isPositive() for detection...

@wilkinsona
Copy link
Member Author

wilkinsona commented Jan 21, 2022

Is there any particular reason to go for that over getAttributes() on KeyStore, @dreis2211? I don't feel strongly about the method that we use, just curious.

@dreis2211
Copy link
Contributor

dreis2211 commented Jan 21, 2022

Duration is probably loaded/initialized already, KeyStore maybe not. Also it's the more widely known class and thus fits better in the currently used ones in JavaVersion. I don't really care either.

@wilkinsona
Copy link
Member Author

Duration is probably loaded/initialized already, KeyStore maybe not.

That's a good point. Ok, let's go with Duration::isPositive(). Thanks for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants