Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-process GraphQL schema resources at build time #29291

Closed
bclozel opened this issue Jan 7, 2022 · 5 comments
Closed

Pre-process GraphQL schema resources at build time #29291

bclozel opened this issue Jan 7, 2022 · 5 comments
Labels
for: external-project For an external project and not something we can fix status: superseded An issue that has been superseded by another theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement

Comments

@bclozel
Copy link
Member

bclozel commented Jan 7, 2022

As seen in spring-projects/spring-graphql#218 (comment), using our Spring GraphQL auto-configuration with the experimental Spring Native project is causing issues.

The Spring Boot auto-configuration for Spring GraphQL is scanning classpath locations for files using the PathMatchingResourcePatternResolver. This approach is not compatible for now with GraalVM (see spring-projects/spring-graphql#230 (comment)).

When a Spring Framework abstraction allows it, we should pre-process this at build time using the upcoming AOT engine and programmatically configure those resources on the GraphQL source builder directly.

@bclozel bclozel added type: enhancement A general enhancement theme: native labels Jan 7, 2022
@bclozel bclozel added this to the 3.0.x milestone Jan 7, 2022
@bclozel bclozel added the status: blocked An issue that's blocked on an external project change label Jan 28, 2022
@bclozel
Copy link
Member Author

bclozel commented Jan 28, 2022

Blocked until a Spring for GraphQL version with Jakarta API is available.

@joshlong
Copy link
Member

hi - i'm sorry I'm missing something. What does Jakarta EE have to do with Spring Graphql and its ability to resolve Resources?

@wilkinsona
Copy link
Member

It's a more general blockage at the moment. Spring for GraphQL uses Jakarta EE APIS (such as the Servlet API, for example) and there is not yet a version of Spring for GraphQL that uses the EE 9 versions of those APIs.

@snicoll
Copy link
Member

snicoll commented Apr 7, 2022

We've started brainstorming how we could do this for entities and that issue looks like yet another case for that need. See #30523.

@bclozel bclozel modified the milestones: 3.0.x, 3.x May 4, 2022
@mbhave mbhave added theme: aot An issue related to Ahead-of-time processing and removed theme: native labels Jun 27, 2022
@bclozel
Copy link
Member Author

bclozel commented Oct 11, 2022

Closing in favor of spring-projects/spring-graphql#495

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2022
@bclozel bclozel added for: external-project For an external project and not something we can fix status: superseded An issue that has been superseded by another and removed status: blocked An issue that's blocked on an external project change labels Oct 11, 2022
@wilkinsona wilkinsona removed this from the 3.x milestone Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: external-project For an external project and not something we can fix status: superseded An issue that has been superseded by another theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants