Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuartzDataSourceScriptDatabaseInitializer does not provide a mapping for MariaDB #28773

Closed
ztomic opened this issue Nov 22, 2021 · 2 comments
Closed

QuartzDataSourceScriptDatabaseInitializer does not provide a mapping for MariaDB #28773

ztomic opened this issue Nov 22, 2021 · 2 comments
Labels
status: superseded An issue that has been superseded by another type: bug A general bug

Comments

@ztomic
Copy link
Contributor

ztomic commented Nov 22, 2021

DatabaseDriver.MYSQL is added two times. Probably one extra line or missing DatabaseDriver.MARIADB.

spring-boot/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/quartz/QuartzDataSourceScriptDatabaseInitializer.java

Line 71 in 196c92e

platformResolver = platformResolver.withDriverPlatform(DatabaseDriver.MYSQL, "mysql_innodb");

spring-boot/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/quartz/QuartzDataSourceScriptDatabaseInitializer.java

Line 72 in 196c92e

platformResolver = platformResolver.withDriverPlatform(DatabaseDriver.MYSQL, "mysql_innodb");

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 22, 2021
@wilkinsona
Copy link
Member

Well spotted. Thank you. One line should be for MARIADB to align with the behaviour of the deprecated QuartzDataSourceInitializer:

spring-boot/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/quartz/QuartzDataSourceInitializer.java

Line 76 in 196c92e

if ("mysql".equals(databaseName) || "mariadb".equals(databaseName)) {

@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 22, 2021
@wilkinsona wilkinsona changed the title Duplicate MYSQL driverMapping in QuartzDataSourceScriptDatabaseInitializer#getSettings QuartzDataSourceScriptDatabaseInitializer does not provide a mapping for MariaDB Nov 22, 2021
@wilkinsona wilkinsona added this to the 2.6.x milestone Nov 22, 2021
ztomic added a commit to ztomic/spring-boot that referenced this issue Nov 23, 2021
@ztomic
Provide mapping for MariaDB in QuartzDataSourceScriptDatabaseInitializer
7b6bf39 
Fixes spring-projects#28773
@ztomic ztomic mentioned this issue Nov 23, 2021
Closed
@wilkinsona
Copy link
Member

Closing in favor of #28779.

@wilkinsona wilkinsona removed this from the 2.6.x milestone Nov 23, 2021
@wilkinsona wilkinsona added status: superseded An issue that has been superseded by another type: bug A general bug and removed type: bug A general bug labels Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

QuartzDataSourceScriptDatabaseInitializer does not provide a mapping for MariaDB ztomic/spring-boot
3 participants
@wilkinsona @ztomic @spring-projects-issues