You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #23818 support for Task Execution and Scheduling Metrics was added.
However, the TaskExecutorMetricsAutoConfiguration uses ExecutorServiceMetrics.monitor(registry, threadPoolExecutor, beanName.get()) to perform the registration. Doing it like this will cause the metrics to also have each ExecutorService to be wrapped in TimedExecutorService and this will register the following metrics:
executor
executor.idle
This metrics are entirely useless because they are never updated since the return type is never used. There is #27041 which is requesting support for those 2 metrics and I think that this is something that can be handled separately. For now I would suggest that the TaskExecutorMetricsAutoConfiguration only calls
snicoll
changed the title
TaskExecutorMetricsAutoConfiguration registers obsolete metrics
Task metrics should not expose time-related metrics as these are not supported yet
Nov 9, 2021
In #23818 support for Task Execution and Scheduling Metrics was added.
However, the
TaskExecutorMetricsAutoConfiguration
usesExecutorServiceMetrics.monitor(registry, threadPoolExecutor, beanName.get())
to perform the registration. Doing it like this will cause the metrics to also have eachExecutorService
to be wrapped inTimedExecutorService
and this will register the following metrics:executor
executor.idle
This metrics are entirely useless because they are never updated since the return type is never used. There is #27041 which is requesting support for those 2 metrics and I think that this is something that can be handled separately. For now I would suggest that the
TaskExecutorMetricsAutoConfiguration
only callsA test case to see this is
The text was updated successfully, but these errors were encountered: