Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default value for NettyProperties.leakDetection is not aligned with Netty's default #27046

Closed
bclozel opened this issue Jun 23, 2021 · 2 comments
Closed

Default value for NettyProperties.leakDetection is not aligned with Netty's default #27046

bclozel opened this issue Jun 23, 2021 · 2 comments
Assignees
@bclozel
Labels
type: bug A general bug
Milestone
2.5.2

Comments

@bclozel
Copy link
Member

bclozel commented Jun 23, 2021

As seen in #26958, the default value for the NettyProperties.leakDetection configuration property does not align with the default value in Netty's ResourceLeakDetector. We should ensure that this is always the case.
@bclozel bclozel added the type: bug A general bug label Jun 23, 2021
@bclozel bclozel added this to the 2.5.2 milestone Jun 23, 2021
@bclozel bclozel self-assigned this Jun 23, 2021
This was referenced Jun 23, 2021
Closed
Closed
@wilkinsona wilkinsona changed the title Align NettyProperties.leakDetection with Netty's defaults Default value for NettyProperties.leakDetection is not aligned with Netty's default Jun 23, 2021
@wilkinsona
Copy link
Member

Re-opening as the test appears to be flakey. I think it's a test ordering problem.

@wilkinsona wilkinsona reopened this Jun 24, 2021
@wilkinsona
Copy link
Member

4572ae5 will hopefully stabilise the test.

wilkinsona added a commit that referenced this issue Jun 24, 2021
@wilkinsona
Use reflection to extract Netty's default level
4572ae5 
See gh-27046
@bclozel bclozel mentioned this issue Jun 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
type: bug A general bug
Projects
None yet
Milestone
2.5.2
Development

No branches or pull requests
2 participants
@bclozel @wilkinsona