EnvironmentPostProcessors aren't instantiated with correct ClassLoader

[jaminh]

Similar to the issue raised in #26126, when using Spring Boot 2.5.0 org.springframework.boot.env.ReflectionEnvironmentPostProcessorsFactory will not use the class loader from the SpringApplication's ResourceLoader when instantiating EnvironmentPostProcessors.

It appears to me the classloader would need to be passed to the instantiator here

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/env/ReflectionEnvironmentPostProcessorsFactory.java

Line 63 in 07c9418

return instantiator.instantiate(this.classNames);

. That way

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/util/Instantiator.java

Line 98 in 07c9418

Class<?> type = ClassUtils.forName(name, null);

could use the correct classloader rather than being passed "null". ReflectionEnvironmentPostProcessorsFactory would need to be made aware of the SpringApplication's ClassLoader as well.

[philwebb]

There are two parts to this bug. The first is that we're not passing a classloader to the Instantiator, the second is that we want to use ResourceLoader.getClassloader().

I'll use this issue to fix the first problem in 2.4.x. The second part we'll fix in 2.5.x under #27071