Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigDataLoaders cannot have a DeferredLogFactory injected preventing their subcomponents from logging accurately #24988

Closed
wilkinsona opened this issue Jan 25, 2021 · 0 comments
Closed

ConfigDataLoaders cannot have a DeferredLogFactory injected preventing their subcomponents from logging accurately #24988

wilkinsona opened this issue Jan 25, 2021 · 0 comments
Assignees
@philwebb
Labels
type: bug A general bug
Milestone
2.4.3

Comments

@wilkinsona
Copy link
Member

At the moment, ConfigDataLoader instances can have a Log injected into their constructor but cannot have a DeferredLogFactory injected. This means that any subcomponents created by a ConfigDataLoader have to use the loader's Log rather than one of their own.

Being able to inject a DeferredLogFactory would be useful for Spring (Cloud) Vault where its VaultConfigDataLoader creates LeaseAwareVaultPropertySource instances that perform some logging.
@wilkinsona wilkinsona added the type: bug A general bug label Jan 25, 2021
@wilkinsona wilkinsona added this to the 2.4.x milestone Jan 25, 2021
@wilkinsona wilkinsona mentioned this issue Jan 25, 2021
Closed
@philwebb philwebb self-assigned this Jan 26, 2021
@philwebb philwebb mentioned this issue Jan 26, 2021
Closed
@philwebb philwebb modified the milestones: 2.4.x, 2.4.3 Jan 26, 2021
This was referenced Mar 11, 2021
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Merged
Closed
Merged
@wind57 wind57 mentioned this issue Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: bug A general bug
Projects
None yet
Milestone
2.4.3
Development

No branches or pull requests
2 participants
@philwebb @wilkinsona