Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop custom ApplicationEnvironment implementation #24892

Closed
philwebb opened this issue Jan 20, 2021 · 2 comments
Closed

Develop custom ApplicationEnvironment implementation #24892

philwebb opened this issue Jan 20, 2021 · 2 comments
Assignees
@philwebb
Labels
theme: config-data Issues related to the configuration theme type: enhancement A general enhancement
Milestone
2.5.0-RC1

Comments

@philwebb
Copy link
Member

We could improve quite a few things if we developed our own Environment implementation rather than relying on StandardEnvironment.

For example, whilst trying to fix #24890 I discovered it's impossible for us to totally filter out spring.profiles.active properties due to AbstractEnvironment.doGetActiveProfiles().

It might also allow us to remove ConfigurationPropertySourcesPropertySource and possibly fix #17400
@philwebb philwebb added type: enhancement A general enhancement theme: config-data Issues related to the configuration theme labels Jan 20, 2021
@philwebb philwebb added this to the 2.5.x milestone Jan 20, 2021
@chaundhyan
Copy link
Contributor

@philwebb
Have you started working on this?
If not, would you assign this enhancement to me?
Thanks

@wilkinsona
Copy link
Member

Thanks for the offer, @chaundhyan. @philwebb is already working on this with with some changes to Spring Framework (see spring-projects/spring-framework#26461 and spring-projects/spring-framework#26462 for details).

@philwebb philwebb modified the milestones: 2.5.x, 2.5.0-RC1 Apr 9, 2021
@nycza nycza mentioned this issue Jun 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
theme: config-data Issues related to the configuration theme type: enhancement A general enhancement
Projects
None yet
Milestone
2.5.0-RC1
Development

No branches or pull requests
3 participants
@philwebb @wilkinsona @chaundhyan