Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jetty 10.0.x #24886

Closed
wilkinsona opened this issue Jan 19, 2021 · 8 comments
Closed

Support Jetty 10.0.x #24886

wilkinsona opened this issue Jan 19, 2021 · 8 comments
Assignees
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Jan 19, 2021

Jetty 10 with Servlet 4 support is out and Framework is looking to support it as soon in 5.3.x as possible (spring-projects/spring-framework#26123). We should look at upgrading to 10.0.x in Boot 2.5 (while perhaps retaining support for Jetty 9.4.x at the same time). This will align Jetty's servlet support with those of Tomcat and Undertow.

@wilkinsona wilkinsona added status: blocked An issue that's blocked on an external project change type: dependency-upgrade A dependency upgrade labels Jan 19, 2021
@wilkinsona wilkinsona added this to the 2.5.x milestone Jan 19, 2021
@dreis2211
Copy link
Contributor

Isn't Jetty 10 (or Jetty 11) requiring Java 11?

@wilkinsona
Copy link
Member Author

You're right, @dreis2211. Thank you. I had mistakenly thought that it was Jetty 11 that both raised the required version of Java and made the switch to the jakarta.* APIs, but those changes appear to be split across 10 and 11.

In light of this, switching to Jetty 10.0.x by default in 2.5 may be too aggressive. We may need to stick with 9.4 while also supporting 10.

@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Jan 19, 2021
@dreis2211
Copy link
Contributor

Just to get that straight: I'd personally love to see the baseline raised. (Regardless of Jetty upgrades) ;-)

@wilkinsona
Copy link
Member Author

Boot's baseline? We'll do that in 3.0 on top of Framework 6.

@philwebb philwebb added status: noteworthy A noteworthy issue to call out in the release notes and removed for: team-attention An issue we'd like other members of the team to review labels Jan 20, 2021
@vK44
Copy link

vK44 commented Jan 22, 2021

jfyi: Jetty 10 will be suppored in Framework 5.3.4, would love to see Boot supports Jetty 10, maybe already in 2.5.0-M2?

@wilkinsona
Copy link
Member Author

Jetty 10 depends on an alpha of SLF4J 2.0 which, in turn, requires Logback users to use an alpha of Logback 1.3. I suspect Log4j2 users will be similarly affected. I've opened jetty/jetty.project#5943.

@wilkinsona
Copy link
Member Author

wilkinsona commented Feb 9, 2021

The changes required to support Jetty 10 while continuing to use Jetty 9.4.x by default are in this branch. We now need to decide if we want to take this approach or switch to using Jetty 10 by default while supporting Jetty 9.4.x.

@wilkinsona wilkinsona removed the status: blocked An issue that's blocked on an external project change label Feb 10, 2021
@wilkinsona wilkinsona changed the title Upgrade to Jetty 10.0.x Support Jetty 10.0.x Feb 17, 2021
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed type: dependency-upgrade A dependency upgrade labels Feb 17, 2021
@wilkinsona
Copy link
Member Author

We're going to support Jetty 10 while sticking with 9.4.x by default for now.

@wilkinsona wilkinsona self-assigned this Feb 17, 2021
@wilkinsona wilkinsona modified the milestones: 2.5.x, 2.5.0-M2 Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants