Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usage description for BufferedApplicationStartup #24605

Closed
ascheman opened this issue Dec 23, 2020 · 3 comments
Closed

Improve usage description for BufferedApplicationStartup #24605

ascheman opened this issue Dec 23, 2020 · 3 comments
Labels
status: superseded An issue that has been superseded by another type: documentation A documentation update

Comments

@ascheman
Copy link

ascheman commented Dec 23, 2020

I was trying the nice new Spring Boot startup tracking feature and used BufferedApplicationStartup to collect initialization data. I found that the collected data is drained from the buffer after each request. In particular, it took me a moment to recognize that the most important data is lost after the first request. As discussed with @bclozel this could be emphasized in the documentation, cf. https://stackoverflow.com/questions/65413579/spring-boot-bufferedapplicationstartup-drained-after-first-request

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 23, 2020
@snicoll snicoll changed the title Enhance documentation for BufferedApplicationStartup (SB >= 2.4.0) Improve usage description for BufferedApplicationStartup Dec 23, 2020
@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 23, 2020
@snicoll snicoll added this to the 2.4.x milestone Dec 23, 2020
@oleg-sukhov
Copy link
Contributor

Hello, @snicoll. I would like to make my first contribution to spring boot project. Do you think that this issue is a good start point? If yes, what should I do to start working on it?

@snicoll
Copy link
Member

snicoll commented Jan 17, 2021

@oleg-sukhov thanks for asking. If you've used the startup feature and see what needs to be documented, please go ahead and submit a PR. The documentation is located in spring-boot-project/spring-boot-docs/src/docs/asciidoc in this repository and the contributing page should provide you more details to get started.

@mbhave
Copy link
Contributor

mbhave commented Feb 2, 2021

Closing in favor of PR #25075.

@mbhave mbhave closed this as completed Feb 2, 2021
@mbhave mbhave removed this from the 2.4.x milestone Feb 2, 2021
oleg-sukhov added a commit to oleg-sukhov/spring-boot that referenced this issue Feb 2, 2021
@snicoll snicoll added the status: superseded An issue that has been superseded by another label Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: documentation A documentation update
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants