Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrorPageFilter is no longer ordered at HIGHEST_PRECEDENCE + 1 #23200

Closed
MTwelkemeier opened this issue Sep 7, 2020 · 0 comments
Closed

ErrorPageFilter is no longer ordered at HIGHEST_PRECEDENCE + 1 #23200

MTwelkemeier opened this issue Sep 7, 2020 · 0 comments
Assignees
@wilkinsona
Labels
type: regression A regression from a previous release
Milestone
2.3.4

Comments

@MTwelkemeier
Copy link

From 2.2.8.RELEASE to 2.3.3.RELEASE, order of ErrorPageFilter has changed from Ordered.HIGHEST_PRECEDENCE + 1 to Ordered.LOWEST_PRECEDENCE.

This causes the filter to handle every exception, originally handled by other filters in the chain.

The changed order might be introduced with #19471. The ErrorPageFilterConfiguration has been enhanced to provide a ServletRegistrationBean for the filter. Since this does not provide an order to the registration bean, it is defaulting to Ordered.LOWEST_PRECEDENCE.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 7, 2020
@wilkinsona wilkinsona added type: regression A regression from a previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 7, 2020
@wilkinsona wilkinsona added this to the 2.3.4 milestone Sep 7, 2020
@wilkinsona wilkinsona self-assigned this Sep 7, 2020
@wilkinsona wilkinsona modified the milestones: 2.3.4, 2.2.10 Sep 7, 2020
@wilkinsona wilkinsona mentioned this issue Sep 7, 2020
Closed
@wilkinsona wilkinsona changed the title Changed order of ErrorPageFilter ErrorPageFilter is no longer ordered at HIGHEST_PRECEDENCE + 1 Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
2.3.4
Development

No branches or pull requests
3 participants
@wilkinsona @spring-projects-issues @MTwelkemeier