Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation on Elasticsearch client configuration #23074

Closed
bclozel opened this issue Aug 25, 2020 · 0 comments
Closed

Fix documentation on Elasticsearch client configuration #23074

bclozel opened this issue Aug 25, 2020 · 0 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Aug 25, 2020

As seen in #22358, applications should define RestClientBuilderCustomizer beans to change the client configuration, not define a RestClient because this won't be used to create the RestHighLevelClient for the application.

Our docs should read:

You can also register an arbitrary number of beans that implement RestClientBuilderCustomizer for more advanced customizations. To take full control over the registration, define a RestClientBuilder bean.

If you have the org.elasticsearch.client:elasticsearch-rest-high-level-client dependency on the classpath, Spring Boot will auto-configure a RestHighLevelClient, which leverages any existing RestClientBuilder bean, reusing its HTTP configuration.

@bclozel bclozel added the type: documentation A documentation update label Aug 25, 2020
@bclozel bclozel added this to the 2.3.x milestone Aug 25, 2020
@snicoll snicoll self-assigned this Aug 31, 2020
@snicoll snicoll modified the milestones: 2.3.x, 2.3.4 Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

2 participants