Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI slack notification message that includes a build scan #21757

Closed
snicoll opened this issue Jun 8, 2020 · 3 comments
Closed

Improve CI slack notification message that includes a build scan #21757

snicoll opened this issue Jun 8, 2020 · 3 comments
Assignees
@dreis2211
Labels
status: superseded An issue that has been superseded by another type: task A general task

Comments

@snicoll
Copy link
Member

snicoll commented Jun 8, 2020

The pattern for our notification is as follows:

spring-boot-2.4.x jdk14-build was successful! [build log] [build scan]

Before the move to Gradle it used to be like this:

 spring-boot-2.1.x build was successful!

Where the whole text is a link to the build log. I suggest we simplify and harmonize the notification message with a build log as follows:

spring-boot-2.4.x jdk14-build was successful! [build scan]

Where the text is back again a link to the build log for consistency.
@snicoll snicoll added the type: task A general task label Jun 8, 2020
@snicoll snicoll added this to the 2.3.x milestone Jun 8, 2020
@dreis2211
Copy link
Contributor

I can tackle that.

@philwebb
Copy link
Member

philwebb commented Jun 8, 2020

Thanks @dreis2211, I've assigned the issue to you.

dreis2211 added a commit to dreis2211/spring-boot that referenced this issue Jun 9, 2020
@dreis2211
Link complete Slack message to build log
63facc6 
Closes spring-projectsgh-21757
dreis2211 added a commit to dreis2211/spring-boot that referenced this issue Jun 9, 2020
@dreis2211
Remove now superfluous braces from Slack message
cac8137 
See spring-projectsgh-21757
@dreis2211 dreis2211 mentioned this issue Jun 9, 2020
Closed
@mbhave
Copy link
Contributor

mbhave commented Jun 9, 2020

Closing in favor of PR #21793.

@mbhave mbhave closed this as completed Jun 9, 2020
@mbhave mbhave added the status: superseded An issue that has been superseded by another label Jun 9, 2020
@mbhave mbhave removed this from the 2.3.x milestone Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreis2211 dreis2211

Labels
status: superseded An issue that has been superseded by another type: task A general task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Link complete Slack message to build log dreis2211/spring-boot
4 participants
@snicoll @philwebb @mbhave @dreis2211