Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note for the moved Elasticsearch auto configuration and RestClientCustomizer in the release notes #21567

Closed
filiphr opened this issue May 25, 2020 · 3 comments
Closed

Add a note for the moved Elasticsearch auto configuration and RestClientCustomizer in the release notes #21567

filiphr opened this issue May 25, 2020 · 3 comments
Assignees
@snicoll
Labels
type: wiki-documentation A documentation update required on the wiki

Comments

@filiphr
Copy link
Contributor

filiphr commented May 25, 2020

We were moving to Spring Boot 2.3 and noticed that the ES auto configuration classes were moved as part of fec386b. The RestClientBuilderCustomizer also got moved. Can this be mentioned in the release notes?

The move of the RestClientBuilderCustomizer is also a breaking change.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 25, 2020
@philwebb philwebb mentioned this issue May 26, 2020
Closed
@philwebb philwebb added type: wiki-documentation A documentation update required on the wiki and removed status: waiting-for-triage An issue we've not yet triaged labels May 26, 2020
@philwebb philwebb added this to the 2.3.x milestone May 26, 2020
@philwebb
Copy link
Member

Sorry about that, we'll update the docs. I've also opened #21572 to see if we can't reintroduce it in a deprecated form.

@filiphr
Copy link
Contributor Author

filiphr commented May 26, 2020

Thanks for understanding

@snicoll snicoll self-assigned this May 28, 2020
@snicoll snicoll removed this from the 2.3.x milestone May 28, 2020
@snicoll
Copy link
Member

snicoll commented May 28, 2020

I've added a note in the deprecation section. The original customizer has been restored in a deprecated fashion in #21572

@snicoll snicoll closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: wiki-documentation A documentation update required on the wiki
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@snicoll @philwebb @filiphr @spring-projects-issues