Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update properties migrator to run on deprecated properties with warn level as well #21425

Closed
snicoll opened this issue May 12, 2020 · 2 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented May 12, 2020

The properties migrator is able to map a deprecated property to its replacement automatically but it does so only if the property is flagged with error level.

At first, it seems a shame we don't expand that mechanism to any deprecated property. Doing that, adding the module would help when something has just been deprecated (but is still honoured) so that the configuration is changed sooner than later.

Flagging for team attention to see if anyone remembers why it is restricted to error level only.

@snicoll snicoll added for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels May 12, 2020
@wilkinsona
Copy link
Member

I can't recall a reason for it being restricted to error level. Expanding it to cover warn-level deprecated properties sounds good to me.

@snicoll snicoll added type: enhancement A general enhancement and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels May 13, 2020
@snicoll snicoll self-assigned this May 13, 2020
@snicoll snicoll added this to the 2.3.0 milestone May 13, 2020
@snicoll
Copy link
Member Author

snicoll commented May 13, 2020

Thanks for the feedback. While doing the change, I think I've remembered. They were not considered as they are still effectively handled. In retrospect, I think I've been too cautious as opting-in for the tool should tell you as much as possible, including about supported deprecation. That count as a warning after all.

@wilkinsona wilkinsona changed the title Update properties migrator to run on on deprecated properties with warn level as well Update properties migrator to run on deprecated properties with warn level as well May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants