Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more extensible constructors on UndertowServletWebServer and UndertowWebServer #21391

Closed
wilkinsona opened this issue May 11, 2020 · 0 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

The constructors on UndertowServletWebServer are heavily overloaded and rather unwieldy. The addition of graceful shutdown support has added to the problem as it's introduced another argument on the constructor. Many of the arguments are passed in so that they can be used to create HttpHandler instances that wrap those from the DeplomentManager. It would be better if this logic was in the factory that creates the server rather than the server itself.

We have a similar, albeit smaller, problem with UndertowWebServer. It would be nice to get rid of the Closeable constructor argument.

@wilkinsona wilkinsona added the type: enhancement A general enhancement label May 11, 2020
@wilkinsona wilkinsona added this to the 2.3.0 milestone May 11, 2020
wilkinsona added a commit to wilkinsona/spring-boot that referenced this issue May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants