Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation attributes are missing from Maven shade transformer configuration in spring-boot-starter-parent #21304

Closed
pse-sonic opened this issue May 4, 2020 · 2 comments
Labels
type: regression A regression from a previous release
Milestone

Comments

@pse-sonic
Copy link

Hi,
I've noticed that the spring-boot-starter-parent probably contains an invalid configuration of the maven-shade-plugin. There is an "empty" transformer delegate.transformer('') which causes a NoSuchMethodException in some cases. The configuration of the transformers has been changed from 2.2.x to 2.3.x.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 4, 2020
@wilkinsona
Copy link
Member

Can you please provide some more information about the NoSuchMethodException? There's an accidental empty <transformer></transformer> in the configuration, but I doubt that would cause a NoSuchMethodException.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label May 4, 2020
@pse-sonic
Copy link
Author

My fault - The empty transformer is also a part of the 2.2.x configuration of the shade plugin.

I figured out that the problem is caused by the missing attribute implementation for all listed transformers. If I override the shade plugin configuration and add these attributes to the transformers (based on the 2.2.x configuration) the problem is solved.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels May 4, 2020
@wilkinsona wilkinsona changed the title Misconfigured maven-shade-plugin - NoSuchMethodException Implementation attributes are missing from Maven shade transformer configuration in spring-boot-starter-parent May 4, 2020
@wilkinsona wilkinsona added type: regression A regression from a previous release and removed status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged labels May 4, 2020
@wilkinsona wilkinsona added this to the 2.3.0 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A regression from a previous release
Projects
None yet
Development

No branches or pull requests

3 participants